-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify retail demo #201
Modify retail demo #201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 93.35% 93.36% +<.01%
==========================================
Files 70 70
Lines 7737 7743 +6
==========================================
+ Hits 7223 7229 +6
Misses 514 514
Continue to review full report at Codecov.
|
Changing this seems to have unexpected consequences on tests. Should not be merged until resolved. Investigating today. |
@@ -176,6 +176,7 @@ def test_saveprogress(entityset): | |||
cutoff_time = pd.DataFrame({'time': times, 'instance_id': range(17)}) | |||
property_feature = IdentityFeature(entityset['log']['value']) > 10 | |||
save_progress = tempfile.mkdtemp() | |||
property_feature.default_value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of property_feature
seems to no longer be tested, in spite of no associated changes to that file. I'm testing it directly here, but we should probably find out the root cause. (tagging @rwedge)
Edit: Recent commits (8-8-2018) have resolved any remaining testing issues. The binary transform coverage loss is still completely mysterious, but aside from that the changes are likely ready for inclusion. The third test in I should note that whatever is causing this behavior isn't the purpose of the test in question, and should probably be independently tested after we figure out what's going on. Calling |
Looks good. Merging |
We change the underlying CSV of the retail demo to include the following:
price
tounit_price
and add atotal
columnunit_price
andtotal
values to be in dollarsIn addition to those changes to the CSV, there were some changes to the
demo.load_retail
function:return_single_table
optional argument to match the other demosorder_products
(which is what it represented) and make new time indices for all of the entities.country
from the customers entity and move it to theorders
entity.