Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid check_primitive function repeatedly asking for available primitives #2016

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Apr 13, 2022

Fixes #1990

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #2016 (2fdfe56) into main (ce5a170) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   99.00%   99.08%   +0.08%     
==========================================
  Files         143      143              
  Lines       16422    16424       +2     
==========================================
+ Hits        16258    16274      +16     
+ Misses        164      150      -14     
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 98.63% <100.00%> (+<0.01%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5a170...2fdfe56. Read the comment docs.

@rwedge rwedge requested a review from dvreed77 April 13, 2022 13:53
Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@rwedge rwedge merged commit 15ef4bf into main Apr 13, 2022
@rwedge rwedge deleted the issue-1990-rw branch April 13, 2022 14:18
@thehomebrewnerd thehomebrewnerd mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor check_primitive() in DeepFeatureSynthesis
2 participants