Skip to content

Remove boolean inputs from MultiplyNumeric#2022

Merged
gsheni merged 9 commits intomainfrom
update-mult-numeric
Apr 26, 2022
Merged

Remove boolean inputs from MultiplyNumeric#2022
gsheni merged 9 commits intomainfrom
update-mult-numeric

Conversation

@thehomebrewnerd
Copy link
Copy Markdown
Contributor

@thehomebrewnerd thehomebrewnerd commented Apr 20, 2022

Remove boolean inputs from MultiplyNumeric

Closes #2020

This PR updates the MultiplyNumeric primitive to have behavior consistent with the other *Numeric primitives. The boolean input types have been removed from the valid input_types. This makes the behavior consistent with the name and the other primitives and will allow multiplication of two numeric columns only.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2022

Codecov Report

Merging #2022 (cc2d1fc) into main (15e40b9) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
- Coverage   99.09%   99.00%   -0.09%     
==========================================
  Files         143      143              
  Lines       16511    16511              
==========================================
- Hits        16361    16347      -14     
- Misses        150      164      +14     
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100.00% <ø> (ø)
...s/tests/primitive_tests/test_transform_features.py 99.85% <ø> (ø)
...ools/tests/primitive_tests/test_primitive_utils.py 100.00% <100.00%> (ø)
...utational_backend/test_calculate_feature_matrix.py 98.80% <0.00%> (-1.20%) ⬇️
...computational_backends/calculate_feature_matrix.py 99.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e40b9...cc2d1fc. Read the comment docs.

Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni requested review from ozzieD and removed request for ozzieD April 26, 2022 16:34
@gsheni gsheni enabled auto-merge (squash) April 26, 2022 16:34
@gsheni gsheni merged commit 401a63d into main Apr 26, 2022
@thehomebrewnerd thehomebrewnerd deleted the update-mult-numeric branch April 26, 2022 16:59
@thehomebrewnerd thehomebrewnerd mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiplyNumeric primitive fails when multiplying IntegerNullable column with Boolean column

3 participants