Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary comparison primitives to properly handle ordinal comparisons #2024

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Update binary comparison primitives to properly handle ordinal comparisons

Closes #2021

Updates the following primitives to return null values if the scalar value used for the comparison is not one of the Ordinal values:

  • GreaterThanScalar
  • GreaterThanEqualToScalar
  • LessThanScalar
  • LessThanEqualToScalar

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2024 (5201f4b) into main (fbbe39b) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   99.08%   98.85%   -0.23%     
==========================================
  Files         143      143              
  Lines       16424    16448      +24     
==========================================
- Hits        16274    16260      -14     
- Misses        150      188      +38     
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 99.85% <100.00%> (+<0.01%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 96.19% <0.00%> (-3.81%) ⬇️
...computational_backends/calculate_feature_matrix.py 99.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbe39b...5201f4b. Read the comment docs.

@thehomebrewnerd thehomebrewnerd merged commit 54c2ba8 into main Apr 20, 2022
@thehomebrewnerd thehomebrewnerd deleted the fix-comparison-prims branch April 20, 2022 22:33
@thehomebrewnerd thehomebrewnerd mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary comparison primitives fail with Ordinal input if scalar value is not in the order values
2 participants