Update binary comparison primitives to properly handle ordinal comparisons#2024
Merged
thehomebrewnerd merged 3 commits intomainfrom Apr 20, 2022
Merged
Update binary comparison primitives to properly handle ordinal comparisons#2024thehomebrewnerd merged 3 commits intomainfrom
thehomebrewnerd merged 3 commits intomainfrom
Conversation
added 2 commits
April 20, 2022 13:06
Codecov Report
@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
- Coverage 99.08% 98.85% -0.23%
==========================================
Files 143 143
Lines 16424 16448 +24
==========================================
- Hits 16274 16260 -14
- Misses 150 188 +38
Continue to review full report at Codecov.
|
rwedge
approved these changes
Apr 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update binary comparison primitives to properly handle ordinal comparisons
Closes #2021
Updates the following primitives to return null values if the scalar value used for the comparison is not one of the Ordinal values:
GreaterThanScalarGreaterThanEqualToScalarLessThanScalarLessThanEqualToScalar