Skip to content

Update slack invite link to new #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 28, 2022
Merged

Update slack invite link to new #2044

merged 20 commits into from
Apr 28, 2022

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 28, 2022 •
edited
Loading

No description provided.

@gsheni gsheni changed the title Update config.yml Update slack link to new Apr 28, 2022
@gsheni gsheni self-assigned this Apr 28, 2022
@gsheni gsheni requested a review from rwedge April 28, 2022 14:34
@gsheni gsheni marked this pull request as ready for review April 28, 2022 14:34
@gsheni gsheni changed the title Update slack link to new Update slack invite link to new Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #2044 (3958091) into main (dbf93db) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
+ Coverage   98.83%   99.06%   +0.22%     
==========================================
  Files         143      143              
  Lines       16586    16586              
==========================================
+ Hits        16393    16431      +38     
+ Misses        193      155      -38
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.23% <0.00%> (+3.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf93db...3958091. Read the comment docs.

@gsheni gsheni enabled auto-merge (squash) April 28, 2022 15:01
@gsheni gsheni requested a review from thehomebrewnerd April 28, 2022 16:20
thehomebrewnerd
thehomebrewnerd suggested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are two more links in contributing.md and one in help.rst

@gsheni
Copy link
Contributor Author

gsheni commented Apr 28, 2022

@thehomebrewnerd fixed

@thehomebrewnerd
Copy link
Contributor

thehomebrewnerd commented Apr 28, 2022

@thehomebrewnerd fixed

@gsheni Not sure what happened, but I'm no longer seeing the changes in README.md, setup.cfg, config.yml and conf.py that were there before.

@gsheni
Copy link
Contributor Author

gsheni commented Apr 28, 2022

@thehomebrewnerd sorry about that. moving too fast. The old links are

The new link is:

@gsheni gsheni merged commit 75705d4 into main Apr 28, 2022
@gsheni gsheni deleted the update_slack_link branch May 19, 2022 18:50
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwedge rwedge Awaiting requested review from rwedge

1 more reviewer

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsheni @thehomebrewnerd