Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete setup.py, MANIFEST.in and move configuration to pyproject.toml #2046

Merged
merged 30 commits into from
May 2, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 29, 2022

  • Delete setup.py and move some configuration to pyproject.toml

With the release of pip v19.1.1 , editable installs are again allowed in the presence of pyproject.toml.

@gsheni gsheni changed the title Update pyproject.toml Delete setup.py and move some configuration to pyproject.toml Apr 29, 2022
@gsheni gsheni self-assigned this Apr 29, 2022
@gsheni gsheni marked this pull request as ready for review April 29, 2022 19:21
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2046 (528d70c) into main (2238f4b) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   98.92%   99.20%   +0.28%     
==========================================
  Files         143      143              
  Lines       16586    16539      -47     
==========================================
  Hits        16407    16407              
+ Misses        179      132      -47     
Impacted Files Coverage Δ
...ools/tests/primitive_tests/test_dask_primitives.py 60.52% <0.00%> (-1.02%) ⬇️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.34% <0.00%> (-0.01%) ⬇️
featuretools/tests/synthesis/test_dfs_method.py 100.00% <0.00%> (ø)
featuretools/entityset/entityset.py 99.21% <0.00%> (+0.11%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 99.07% <0.00%> (+0.45%) ⬆️
featuretools/feature_base/feature_base.py 97.53% <0.00%> (+0.63%) ⬆️
featuretools/__main__.py 61.53% <0.00%> (+0.82%) ⬆️
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️
featuretools/synthesis/encode_features.py 98.78% <0.00%> (+1.16%) ⬆️
featuretools/demo/flight.py 96.10% <0.00%> (+1.16%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2238f4b...528d70c. Read the comment docs.

@gsheni gsheni enabled auto-merge (squash) April 29, 2022 19:56
@gsheni gsheni disabled auto-merge April 29, 2022 19:58
@rwedge
Copy link
Contributor

rwedge commented Apr 29, 2022

The oldest pip version I could get to make an editable install was 21.1, if that makes any difference

@gsheni
Copy link
Contributor Author

gsheni commented Apr 29, 2022

@rwedge I think that is fine.

I also deleted Manifest.in, see my comment on PR desc.

@gsheni gsheni changed the title Delete setup.py and move some configuration to pyproject.toml Delete setup.py, MANIFEST.in and move configuration to pyproject.toml Apr 29, 2022
@gsheni
Copy link
Contributor Author

gsheni commented Apr 29, 2022

@rwedge @thehomebrewnerd ready for review

setup.cfg Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
rwedge
rwedge previously approved these changes Apr 29, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming tests pass

@gsheni gsheni requested a review from rwedge May 2, 2022 14:13
docs/source/release_notes.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested both building and installing locally and all seemed to work as expected.

@gsheni gsheni enabled auto-merge (squash) May 2, 2022 14:29
@gsheni gsheni merged commit 74bfdb4 into main May 2, 2022
@gsheni gsheni deleted the fix_toml branch May 19, 2022 18:50
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants