Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip Dask test for test_normalize_with_invalid_time_index in test_es.py due to different error message in WW 0.16.3 #2052

Merged
merged 8 commits into from
May 4, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 4, 2022

No description provided.

@gsheni gsheni self-assigned this May 4, 2022
@gsheni gsheni changed the title Restrict Woodwork 0.16.3 from being required Prevent Woodwork 0.16.3 from being installed May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2052 (746aa07) into main (6cd7469) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
- Coverage   99.20%   99.15%   -0.05%     
==========================================
  Files         143      143              
  Lines       16539    16540       +1     
==========================================
- Hits        16407    16401       -6     
- Misses        132      139       +7     
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...utational_backend/test_calculate_feature_matrix.py 99.23% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd7469...746aa07. Read the comment docs.

@@ -38,7 +38,7 @@ jobs:
- name: Install Woodwork & Featuretools - test requirements
run: |
python -m pip install -e unpacked_sdist/[test]
python -m pip install -U git+https://github.com/alteryx/woodwork
python -m pip install --upgrade --force-reinstall https://github.com/alteryx/woodwork/archive/main.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need --upgrade if we are using --force-reinstall

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@thehomebrewnerd thehomebrewnerd changed the title Prevent Woodwork 0.16.3 from being installed Temporarily skip Dask test for test_normalize_with_invalid_time_index in test_es.py due to different error message in WW 0.16.3 May 4, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming tests pass

@thehomebrewnerd thehomebrewnerd enabled auto-merge (squash) May 4, 2022 22:46
@thehomebrewnerd thehomebrewnerd merged commit e184ff1 into main May 4, 2022
@gsheni gsheni deleted the restrict_ww branch May 19, 2022 18:50
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants