Update DateToHoliday and DistanceToHoliday primitives to work with timezone-aware inputs #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2056 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 143 143
Lines 16540 16554 +14
=======================================
+ Hits 16408 16422 +14
Misses 132 132
Continue to review full report at Codecov.
|
rwedge
reviewed
May 11, 2022
| @@ -201,7 +201,7 @@ def distance_to_holiday(x): | |||
| df["x_index"] = df.index # store original index as a column | |||
| df = df.dropna() | |||
| df = df.sort_values("date") | |||
| df.date = df.date.dt.normalize() | |||
| df.date = df.date.dt.normalize().dt.date.astype("datetime64[ns]") | |||
There was a problem hiding this comment.
do we need to normalize if we are also extracting the date?
There was a problem hiding this comment.
No, the normalize calls aren't necessary anymore. Removed. Also updated to (I think) improve readability of these lines a little bit.
| ), | ||
| "non_timezone_aware_no_time": pd.date_range("2018-07-03", periods=3), | ||
| "timezone_aware_with_time": pd.date_range( | ||
| "2018-07-03 09:00", periods=3 |
There was a problem hiding this comment.
should we test with times where if converted to UTC, some times would change dates?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
DateToHolidayandDistanceToHolidayprimitives to work with timezone-aware inputs and adds new tests to verify the correct answer is returned.