Set class name for Min #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
- Coverage 93.36% 93.35% -0.01%
==========================================
Files 70 70
Lines 7743 7738 -5
==========================================
- Hits 7229 7224 -5
Misses 514 514
Continue to review full report at Codecov.
|
kmax12
reviewed
Aug 9, 2018
| name="min", | ||
| stack_on_self=False, | ||
| description="Finds the minimum non-null value of a numeric feature.") | ||
| # Min = make_agg_primitive( |
There was a problem hiding this comment.
might as well delete this code
|
Looks good. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minso the class name is set after creation.