Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set class name for Min #206

merged 4 commits into from Aug 10, 2018

Set class name for Min #206

merged 4 commits into from Aug 10, 2018


Copy link

@gsheni gsheni commented Aug 9, 2018

  • Changed primitive Min so the class name is set after creation.

Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #206 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
- Coverage   93.36%   93.35%   -0.01%     
  Files          70       70              
  Lines        7743     7738       -5     
- Hits         7229     7224       -5     
  Misses        514      514
Impacted Files Coverage Δ
featuretools/primitives/ 92.6% <100%> (+0.03%) ⬆️
featuretools/tests/entityset_tests/ 99.31% <0%> (-0.01%) ⬇️
featuretools/demo/ 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d220e...02177e5. Read the comment docs.

description="Finds the minimum non-null value of a numeric feature.")
# Min = make_agg_primitive(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well delete this code

@kmax12 kmax12 changed the title prefer class for Min (WIP) prefer class for Min Aug 9, 2018
@gsheni gsheni changed the title (WIP) prefer class for Min Set class name for Min Aug 10, 2018
Copy link

kmax12 commented Aug 10, 2018

Looks good. Merging

@kmax12 kmax12 merged commit d1ab519 into master Aug 10, 2018
@gsheni gsheni deleted the min_fix branch August 10, 2018 19:59
@rwedge rwedge mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants