Skip to content

Add workflow to kickoff EvalML unit tests with Featuretools main #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2022
Merged

Add workflow to kickoff EvalML unit tests with Featuretools main #2072

merged 5 commits into from
May 12, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 12, 2022

No description provided.

@gsheni gsheni self-assigned this May 12, 2022
@gsheni gsheni requested review from chukarsten and rwedge May 12, 2022 14:39
chukarsten
chukarsten previously approved these changes May 12, 2022
View reviewed changes
Copy link

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsheni gsheni enabled auto-merge (squash) May 12, 2022 14:51
@gsheni gsheni disabled auto-merge May 12, 2022 14:52
@gsheni gsheni enabled auto-merge (squash) May 12, 2022 14:55
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #2072 (1605baf) into main (13ecb6d) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
+ Coverage   99.11%   99.20%   +0.08%     
==========================================
  Files         143      143              
  Lines       16554    16554              
==========================================
+ Hits        16408    16422      +14     
+ Misses        146      132      -14
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 100.00% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ecb6d...1605baf. Read the comment docs.

rwedge
rwedge reviewed May 12, 2022
View reviewed changes
@gsheni gsheni disabled auto-merge May 12, 2022 15:33
rwedge
rwedge approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 4da1218 into main May 12, 2022
@gsheni gsheni deleted the add_kickoff_evalml branch May 12, 2022 17:22
@gsheni gsheni mentioned this pull request May 12, 2022
Merged
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@chukarsten chukarsten chukarsten left review comments

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsheni @rwedge @chukarsten