Skip to content

Update Dask cluster tests#2079

Merged
thehomebrewnerd merged 4 commits into
mainfrom
dask-flake
May 16, 2022
Merged

Update Dask cluster tests#2079
thehomebrewnerd merged 4 commits into
mainfrom
dask-flake

Conversation

@thehomebrewnerd

@thehomebrewnerd thehomebrewnerd commented May 16, 2022

Copy link
Copy Markdown
Contributor

Updates test fixtures to prevent flaky Dask test behavior

Closes #2038

While this update seems to work on the surface, verifying this actually fixes the problem is a big challenging since the coverage tests don't fail consistently. If the changes in this PR do not fix the problem, we might try using the gen_cluster approach described in this issue: dask/distributed#4479

@thehomebrewnerd thehomebrewnerd marked this pull request as draft May 16, 2022 15:14
@codecov

codecov Bot commented May 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2079 (2d26358) into main (8d09210) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2079      +/-   ##
==========================================
+ Coverage   99.11%   99.20%   +0.08%     
==========================================
  Files         143      143              
  Lines       16554    16555       +1     
==========================================
+ Hits        16408    16423      +15     
+ Misses        146      132      -14     
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 100.00% <100.00%> (+1.19%) ⬆️
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
featuretools/tests/synthesis/test_dfs_method.py 100.00% <100.00%> (ø)
...computational_backends/calculate_feature_matrix.py 100.00% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d09210...2d26358. Read the comment docs.

@thehomebrewnerd thehomebrewnerd requested a review from rwedge May 16, 2022 16:27
@thehomebrewnerd thehomebrewnerd marked this pull request as ready for review May 16, 2022 16:27

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit 7f77d84 into main May 16, 2022
@thehomebrewnerd thehomebrewnerd deleted the dask-flake branch May 16, 2022 19:15
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flaky Dask test behavior

2 participants