Skip to content

add utils function for grabbing primitive metrics#2099

Merged
ozzieD merged 21 commits intomainfrom
2051-add-helper-summerized-primative-metrics
Jun 22, 2022
Merged

add utils function for grabbing primitive metrics#2099
ozzieD merged 21 commits intomainfrom
2051-add-helper-summerized-primative-metrics

Conversation

@ozzieD
Copy link
Copy Markdown
Contributor

@ozzieD ozzieD commented May 27, 2022

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2022

Codecov Report

Merging #2099 (0951508) into main (210741d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #2099    +/-   ##
========================================
  Coverage   99.21%   99.21%            
========================================
  Files         143      143            
  Lines       16728    16833   +105     
========================================
+ Hits        16596    16701   +105     
  Misses        132      132            
Impacted Files Coverage Δ
featuretools/primitives/api.py 100.00% <ø> (ø)
featuretools/__init__.py 73.33% <100.00%> (ø)
featuretools/primitives/base/primitive_base.py 100.00% <100.00%> (ø)
featuretools/primitives/utils.py 99.60% <100.00%> (+0.10%) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210741d...0951508. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just taking a quick pass, will look more later

Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py
Comment thread docs/source/release_notes.rst Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread docs/source/getting_started/primitives.ipynb Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/tests/primitive_tests/test_primitive_utils.py Outdated
Comment thread featuretools/tests/primitive_tests/test_primitive_utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
Comment thread docs/source/getting_started/primitives.ipynb Outdated
@ozzieD ozzieD changed the title Draft: add utils function for grabbing primitive metrics add utils function for grabbing primitive metrics Jun 3, 2022
@alteryx alteryx deleted a comment from CLAassistant Jun 21, 2022
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 21, 2022

CLA assistant check
All committers have signed the CLA.

@ozzieD ozzieD force-pushed the 2051-add-helper-summerized-primative-metrics branch from aa94628 to e4cd69c Compare June 21, 2022 17:21
@rwedge
Copy link
Copy Markdown
Contributor

rwedge commented Jun 21, 2022

Screen Shot 2022-06-21 at 3 04 10 PM

Should we modify how we present info on categorical / numeric primitives? Many primitives only look for the "category" tag or the "numeric" tag, not the "Categorical" logical type or a specific numeric logical type

Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/tests/primitive_tests/test_primitive_utils.py Outdated
@ozzieD
Copy link
Copy Markdown
Contributor Author

ozzieD commented Jun 21, 2022

Screen Shot 2022-06-21 at 3 04 10 PM

Should we modify how we present info on categorical / numeric primitives? Many primitives only look for the "category" tag or the "numeric" tag, not the "Categorical" logical type or a specific numeric logical type

hmm I think we are only providing metrics for how many times these logical types get used as inputs. We could do it for the semantic tags as well but I think when we discussed this issue originally we only wanted to get the metrics for logical type inputs. @gsheni what do you think?

@gsheni
Copy link
Copy Markdown
Contributor

gsheni commented Jun 21, 2022

@ozzieD if it's an easy lift, let's provide information on semantic tag usage.

Comment thread featuretools/primitives/utils.py Outdated
Comment thread featuretools/primitives/utils.py Outdated
@ozzieD ozzieD merged commit 33e4b31 into main Jun 22, 2022
@ozzieD ozzieD deleted the 2051-add-helper-summerized-primative-metrics branch June 22, 2022 19:05
@sbadithe sbadithe mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add helper function to summarized primitive as dataframe

7 participants