/ featuretools Public
Fixed Diff primitive for rare nan case #21
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I ran into a bug with the
Diffprimitive that occurs when for a single variable and cutoff time, all values of both the variable and the feature to group by are nan. The bug occurs because Pandas drops the column names of empty dataframes, so we get a KeyError. This fix required a new variable in the mock entityset because we needed both an Id variable to group on that had a nan value and a numeric variable that had a nan.