Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature origin to all feature matrix columns #2102

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Add feature origin to all feature matrix columns

Closes #2100

Updates get_ww_types_from_features util function to make sure feature origins are added to all columns in a feature matrix. Previously, only the last column of a multi-output feature had the origin information added.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2102 (084b3db) into main (959b629) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2102   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         143      143           
  Lines       16555    16569   +14     
=======================================
+ Hits        16423    16437   +14     
  Misses        132      132           
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 96.44% <100.00%> (ø)
...utational_backend/test_calculate_feature_matrix.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959b629...084b3db. Read the comment docs.

tamargrey
tamargrey previously approved these changes Jun 7, 2022
Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@thehomebrewnerd thehomebrewnerd merged commit cb941c1 into main Jun 10, 2022
@thehomebrewnerd thehomebrewnerd deleted the feature-orig-bug branch June 10, 2022 14:01
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature origins are not stored on all columns of a multi-output primitive
2 participants