Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing instructions to include pandoc #2104

Merged
merged 15 commits into from
Jun 13, 2022
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 9, 2022

  • Update Dockerfile instructions
  • Add pandoc to contributing.md

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2104 (10f35ba) into main (19fe98d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         143      143           
  Lines       16569    16569           
=======================================
  Hits        16437    16437           
  Misses        132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fe98d...10f35ba. Read the comment docs.

@gsheni gsheni self-assigned this Jun 9, 2022
@gsheni gsheni requested a review from cp2boston June 9, 2022 23:18
@gsheni gsheni changed the title Update install.md Update contributing instructions to include pandoc Jun 9, 2022
@gsheni gsheni marked this pull request as ready for review June 9, 2022 23:23
@thehomebrewnerd
Copy link
Contributor

@gsheni I may be a bit out of the loop on this PR, but did something change that requires us to now install pandoc when we didn't need to previously?

contributing.md Outdated Show resolved Hide resolved
@gsheni
Copy link
Contributor Author

gsheni commented Jun 13, 2022

@thehomebrewnerd We always needed to install pandoc to build the docs. This just adds it to the contributing doc

@thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd We always needed to install pandoc to build the docs. This just adds it to the contributing doc

Hmm...ok. I never recall installing it previously, but maybe I have just forgotten. I definitely can't build now without installing though.

contributing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not well-versed enough in Docker to know if the updates for the dockerfile all good, but they seem ok to me.

@gsheni gsheni requested a review from rwedge June 13, 2022 16:23
@gsheni gsheni disabled auto-merge June 13, 2022 16:35
rwedge
rwedge previously approved these changes Jun 13, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker image worked for me!

@gsheni gsheni enabled auto-merge (squash) June 13, 2022 16:48
@gsheni gsheni merged commit 80e3beb into main Jun 13, 2022
@gsheni gsheni deleted the update_install branch June 13, 2022 18:03
@sbadithe sbadithe mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants