-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing instructions to include pandoc #2104
Conversation
gsheni
commented
Jun 9, 2022
•
edited
Loading
edited
- Update Dockerfile instructions
- Add pandoc to contributing.md
Codecov Report
@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 143 143
Lines 16569 16569
=======================================
Hits 16437 16437
Misses 132 132 Continue to review full report at Codecov.
|
@gsheni I may be a bit out of the loop on this PR, but did something change that requires us to now install pandoc when we didn't need to previously? |
@thehomebrewnerd We always needed to install pandoc to build the docs. This just adds it to the contributing doc |
Hmm...ok. I never recall installing it previously, but maybe I have just forgotten. I definitely can't build now without installing though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not well-versed enough in Docker to know if the updates for the dockerfile all good, but they seem ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker image worked for me!