Remove nlp[complete] requirement from dev requirements #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
previously approved these changes
Jun 15, 2022
|
@rwedge Missing the release notes |
|
@gsheni I want to fix some docstrings in NLP primitives, do a bugfix NLP release, and then add those primitives to this API Ref |
gsheni
approved these changes
Jun 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #2109 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 143 143
Lines 16585 16585
=======================================
Hits 16453 16453
Misses 132 132 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to install the "complete" version of
nlp_primitivesin order to build the docs. The standard version ofnlp_primitiveswill still be needed.