Skip to content

Remove nlp[complete] requirement from dev requirements#2109

Merged
rwedge merged 8 commits into
mainfrom
remove-nlp-complete-from-dev
Jun 17, 2022
Merged

Remove nlp[complete] requirement from dev requirements#2109
rwedge merged 8 commits into
mainfrom
remove-nlp-complete-from-dev

Conversation

@rwedge

@rwedge rwedge commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

This PR removes the need to install the "complete" version of nlp_primitives in order to build the docs. The standard version of nlp_primitives will still be needed.

gsheni
gsheni previously approved these changes Jun 15, 2022
@gsheni

gsheni commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

@rwedge Missing the release notes

@rwedge

rwedge commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

@gsheni I want to fix some docstrings in NLP primitives, do a bugfix NLP release, and then add those primitives to this API Ref

@rwedge rwedge requested a review from gsheni June 17, 2022 19:51
@codecov

codecov Bot commented Jun 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2109 (8bd5e8b) into main (5615776) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2109   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         143      143           
  Lines       16585    16585           
=======================================
  Hits        16453    16453           
  Misses        132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5615776...8bd5e8b. Read the comment docs.

@rwedge rwedge merged commit 656b50d into main Jun 17, 2022
@rwedge rwedge deleted the remove-nlp-complete-from-dev branch June 17, 2022 20:08
@sbadithe sbadithe mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants