Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use capital name for Min primitive #211

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Use capital name for Min primitive #211

merged 1 commit into from
Aug 14, 2018

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 14, 2018

  • use make_agg_primitive to set the capital name for Min

@gsheni gsheni changed the title use capital name Use capital name for Min primitive Aug 14, 2018
@codecov-io
Copy link

Codecov Report

Merging #211 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   93.46%   93.46%   -0.01%     
==========================================
  Files          71       71              
  Lines        7785     7783       -2     
==========================================
- Hits         7276     7274       -2     
  Misses        509      509
Impacted Files Coverage Δ
featuretools/primitives/aggregation_primitives.py 92.57% <ø> (-0.04%) ⬇️
featuretools/demo/flight.py 88.37% <0%> (-0.27%) ⬇️
featuretools/demo/retail.py 100% <0%> (ø) ⬆️
featuretools/tests/demo_tests/test_demo_data.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f30e3...8d8cb3f. Read the comment docs.

@kmax12 kmax12 merged commit 0990175 into master Aug 14, 2018
@rwedge rwedge mentioned this pull request Aug 20, 2018
@kmax12 kmax12 deleted the min_fix_2 branch October 2, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants