Merged
Conversation
dvreed77
reviewed
Jun 16, 2022
featuretools/primitives/standard/datetime_transform_primitives.py
Outdated
Show resolved
Hide resolved
gsheni
reviewed
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #2110 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 143 143
Lines 16569 16585 +16
=======================================
+ Hits 16437 16453 +16
Misses 132 132
Continue to review full report at Codecov.
|
tamargrey
reviewed
Jun 17, 2022
| doy = DayOfYear() | ||
| dates = pd.Series(datetime(2020, 12, 31)) | ||
| days_of_year = doy(dates) | ||
| correct_days = [366] |
Contributor
There was a problem hiding this comment.
I like that this tests the leap year case!
tamargrey
approved these changes
Jun 17, 2022
Contributor
tamargrey
left a comment
tamargrey
left a comment
There was a problem hiding this comment.
This looks good to me!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean PR for implementing DayOfYear primitive