Implementing More Datetime Primitives#2117
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 143 143
Lines 16585 16665 +80
=======================================
+ Hits 16453 16533 +80
Misses 132 132
Continue to review full report at Codecov.
|
…eryx/featuretools into add-more-datetime-primitives Pulling changes
…eryx/featuretools into add-more-datetime-primitives pulling merge
gsheni
reviewed
Jun 17, 2022
docs/source/release_notes.rst
Outdated
Comment on lines
+9
to
+14
| * Implement ``DaysInMonth`` primitive (:pr:`2117`) | ||
| * Implement ``Quarter`` primitive (:pr:`2117`) | ||
| * Implement ``IsLeapYear`` primitive (:pr:`2117`) | ||
| * Implement ``IsQuarterEnd`` primitive (:pr:`2117`) | ||
| * Implement ``IsQuarterStart`` primitive (:pr:`2117`) | ||
| * Implement ``DayOfYear`` primitive (:pr:`2110`) |
Contributor
There was a problem hiding this comment.
Suggested change
| * Implement ``DaysInMonth`` primitive (:pr:`2117`) | |
| * Implement ``Quarter`` primitive (:pr:`2117`) | |
| * Implement ``IsLeapYear`` primitive (:pr:`2117`) | |
| * Implement ``IsQuarterEnd`` primitive (:pr:`2117`) | |
| * Implement ``IsQuarterStart`` primitive (:pr:`2117`) | |
| * Implement ``DayOfYear`` primitive (:pr:`2110`) | |
| * Add ``DaysInMonth``, ``Quarter`` , ``IsLeapYear`` , ``IsQuarterEnd`` , ``IsQuarterStart``, ``DayOfYear`` transform primitives (:pr:`2110`) |
Contributor
|
Do we need to worry about timezone aware datetimes with any of these primitives? |
Contributor
Author
I do not believe so |
dvreed77
reviewed
Jun 17, 2022
|
|
||
| def test_days_in_month(): | ||
| dim = DaysInMonth() | ||
| dates = pd.Series([datetime(2010, 1, 1)]) |
Contributor
There was a problem hiding this comment.
add more test cases. Add february of leap year and not leap year
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on adding more datetime primitives: