Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RollingOutlierCount primitive #2129

Merged
merged 32 commits into from
Nov 2, 2022
Merged

Add RollingOutlierCount primitive #2129

merged 32 commits into from
Nov 2, 2022

Conversation

tamargrey
Copy link
Contributor

closes #1804

@tamargrey tamargrey removed the request for review from thehomebrewnerd June 21, 2022 19:59
@tamargrey tamargrey force-pushed the rolling-outlier-count branch from fedd26b to 3f5e309 Compare June 21, 2022 20:17
@tamargrey tamargrey marked this pull request as draft June 23, 2022 13:18
@gsheni
Copy link
Contributor

gsheni commented Aug 2, 2022

@tamargrey @ozzieD Should we wait until this issue (#2213) is completed before revisiting this?

@tamargrey
Copy link
Contributor Author

@gsheni Yeah, I think that makes sense

@gsheni
Copy link
Contributor

gsheni commented Aug 8, 2022

@tamargrey #2213 has been completed so we can revisit this PR.

@sbadithe sbadithe self-assigned this Oct 27, 2022
@sbadithe sbadithe force-pushed the rolling-outlier-count branch from 3827955 to 4e17b42 Compare October 27, 2022 01:52
@sbadithe sbadithe changed the title Add rolling outlier count primitive [DRAFT] Add rolling outlier count primitive Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #2129 (29800d6) into main (cfa19d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         310      311    +1     
  Lines       19773    19814   +41     
=======================================
+ Hits        19660    19701   +41     
  Misses        113      113           
Impacted Files Coverage Δ
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.34% <ø> (ø)
...mitives/standard/transform/time_series/__init__.py 100.00% <100.00%> (ø)
...ard/transform/time_series/rolling_outlier_count.py 100.00% <100.00%> (ø)
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
...ls/tests/primitive_tests/test_rolling_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe sbadithe changed the title Add rolling outlier count primitive Add RollingOutlierCount primitive Oct 31, 2022
@sbadithe sbadithe requested a review from ozzieD October 31, 2022 18:52
@tamargrey
Copy link
Contributor Author

Can you add RollingOutlierCount to the test_rolling_primitives_non_uniform test? (Or, if it needs a slightly different handling, make a separate test for it like test_rolling_std_non_uniform and test_rolling_trend_non_uniform)

@gsheni
Copy link
Contributor

gsheni commented Nov 1, 2022

@sbadithe I believe this should be good to go (once the lint issue is fixed).

@tamargrey
Copy link
Contributor Author

I can't officially approve bc I'm the original author of this PR 🙈 , but this looks good to me!

@sbadithe sbadithe merged commit 0e1f4f5 into main Nov 2, 2022
@sbadithe sbadithe deleted the rolling-outlier-count branch November 2, 2022 17:22
@gsheni gsheni mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RollingOutlierCount primitive
5 participants