-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RollingOutlierCount primitive #2129
Conversation
fedd26b
to
3f5e309
Compare
@tamargrey @ozzieD Should we wait until this issue (#2213) is completed before revisiting this? |
@gsheni Yeah, I think that makes sense |
@tamargrey #2213 has been completed so we can revisit this PR. |
3827955
to
4e17b42
Compare
Codecov Report
@@ Coverage Diff @@
## main #2129 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 310 311 +1
Lines 19773 19814 +41
=======================================
+ Hits 19660 19701 +41
Misses 113 113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
featuretools/primitives/standard/transform/time_series/rolling_outlier_count.py
Outdated
Show resolved
Hide resolved
featuretools/primitives/standard/transform/time_series/rolling_outlier_count.py
Outdated
Show resolved
Hide resolved
featuretools/primitives/standard/transform/time_series/rolling_outlier_count.py
Outdated
Show resolved
Hide resolved
Can you add RollingOutlierCount to the |
@sbadithe I believe this should be good to go (once the lint issue is fixed). |
featuretools/primitives/standard/transform/time_series/rolling_outlier_count.py
Outdated
Show resolved
Hide resolved
featuretools/primitives/standard/transform/time_series/rolling_outlier_count.py
Outdated
Show resolved
Hide resolved
I can't officially approve bc I'm the original author of this PR 🙈 , but this looks good to me! |
closes #1804