Fixes for numpy 1.23.0 #2137
Merged
Fixes for numpy 1.23.0 #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 23, 2022 08:50
gsheni
previously approved these changes
Jun 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #2137 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 143 143
Lines 16833 16835 +2
=======================================
+ Hits 16701 16703 +2
Misses 132 132
Continue to review full report at Codecov.
|
gsheni
reviewed
Jun 23, 2022
| @@ -881,7 +881,10 @@ def __init__(self, commutative=False): | |||
| self.commutative = commutative | |||
|
|
|||
| def get_function(self): | |||
| return np.divide | |||
| def divide_numeric(val1, val2): | |||
There was a problem hiding this comment.
When primitives directly return a function, it tends to be faster. Is there no way to keep using np.divide?
There was a problem hiding this comment.
Not sure it makes a difference in this particular case - perhaps because we are using optimized approaches in both cases (numpy vs pandas)?
gsheni
approved these changes
Jun 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for numpy 1.23.0
Implement fixes for compatibility with numpy 1.23.0
With numpy 1.23.0 the
np.dividefunction used in theDivideNumericprimitive now generates an error with pyspark inputs.To resolve, the primitive was updated to divide the two series directly rather than using the np.divide function.
Also had to update the doctest for the
NaturalLogarithmprimitive to round primitive output to account for slightly different floating point output with the new version of numpy.