Refactor feature serialization to avoid storing duplicate primitive information #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 24, 2022 14:20
Codecov Report
@@ Coverage Diff @@
## serialization-updates #2144 +/- ##
======================================================
Coverage 99.23% 99.23%
======================================================
Files 143 143
Lines 17035 17100 +65
======================================================
+ Hits 16904 16969 +65
Misses 131 131
Continue to review full report at Codecov.
|
rwedge
reviewed
Jun 29, 2022
| primitives_dict_key = str(primitive_number) | ||
| primitive_id_to_key[primitive_id] = primitives_dict_key | ||
| self._primitives_dict[ | ||
| str(primitives_dict_key) |
There was a problem hiding this comment.
primitives_dict_key is already cast to string on line 118
There was a problem hiding this comment.
Yep, sure is. Fixed 9e6830c
rwedge
approved these changes
Jun 29, 2022
|
Looks like Windows tests are failing due to some unrelated graphviz issue and one failed due to codecov (possibly due to github api problems), so going ahead and merging this into the feature branch. |
thehomebrewnerd
added a commit
that referenced
this pull request
Jun 30, 2022
…2136) * serialization and deserialization improvements * add pr number * Improve feature deserialization to use common primitive instances (#2127) * update feature deserialization * update release notes * lint fix * fix comment * fix for list inputs and test cleanup * remove files * remove file * use tmp_path * Allow users to directly set feature output column names and save during serialization (#2142) * add set_feature_names method * initial serialization updates * update release notes * fix tests * code cleanup - only store names when set * only use on multi-output features * fix test * lint fix * remove unused functions * add more test cases * update serialization test * Update featuretools/feature_base/feature_base.py Co-authored-by: Roy Wedge <roy.wedge@alteryx.com> Co-authored-by: Roy Wedge <roy.wedge@alteryx.com> * Refactor feature serialization to avoid storing duplicate primitive information (#2144) * initial refactor of serialization * update release notes * lint and remove breakpoint * new approach without hash * refactor and update tests * remove comment * update s3 file * update feature base args * lint fix * misc cleanup * remove extra str casting * fix spelling error * remove instance cache * update save and load docstring examples * lint fix * more docstring cleanup * update release notes * tweak serialization * update json Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor feature serialization to avoid storing duplicate primitive information
Separates storage of primitive information from feature information to avoid storing duplicate primitive information when serializing features.