Skip to content

Adding NaN test cases for non-boolean returning datetime primitives#2146

Merged
sbadithe merged 5 commits into
mainfrom
adding-nan-datetime-primitive-test-cases
Jun 28, 2022
Merged

Adding NaN test cases for non-boolean returning datetime primitives#2146
sbadithe merged 5 commits into
mainfrom
adding-nan-datetime-primitive-test-cases

Conversation

@sbadithe

Copy link
Copy Markdown
Contributor

Adds test cases for new datetime primitives that checks for np.nan input.

@codecov

codecov Bot commented Jun 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2146 (c14d110) into main (dc0279d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         143      143           
  Lines       16837    16837           
=======================================
  Hits        16705    16705           
  Misses        132      132           
Impacted Files Coverage Δ
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0279d...c14d110. Read the comment docs.

@sbadithe sbadithe marked this pull request as ready for review June 27, 2022 15:51
@sbadithe sbadithe changed the title [DRAFT] Adding NaN test cases for non-boolean returning datetime primitives Adding NaN test cases for non-boolean returning datetime primitives Jun 27, 2022
@sbadithe sbadithe requested a review from dvreed77 June 27, 2022 21:49
dvreed77
dvreed77 previously approved these changes Jun 28, 2022

@dvreed77 dvreed77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvreed77 dvreed77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbadithe sbadithe merged commit 4f35a15 into main Jun 28, 2022
@sbadithe sbadithe deleted the adding-nan-datetime-primitive-test-cases branch June 28, 2022 16:58
@ozzieD ozzieD mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants