Skip to content

Sort requirements and test requirements in setup.cfg #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2022
Merged

Sort requirements and test requirements in setup.cfg #2152

merged 2 commits into from
Jun 28, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 28, 2022 •
edited
Loading

  • To make it easier to compare with conda feedstock

@gsheni gsheni self-assigned this Jun 28, 2022
@gsheni gsheni requested a review from rwedge June 28, 2022 03:28
@gsheni gsheni changed the title Update setup.cfg Sort requirements in setupcfg Jun 28, 2022
@gsheni gsheni changed the title Sort requirements in setupcfg Sort requirements and test requirements in setup.cfg Jun 28, 2022
@gsheni gsheni marked this pull request as ready for review June 28, 2022 03:30
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #2152 (ffee431) into main (498e29c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2152   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         143      143           
  Lines       16837    16837           
=======================================
  Hits        16705    16705           
  Misses        132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498e29c...ffee431. Read the comment docs.

@gsheni gsheni enabled auto-merge (squash) June 28, 2022 04:46
rwedge
rwedge approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Are we planning to sort the rest eventually?

@gsheni gsheni merged commit 60ed880 into main Jun 28, 2022
@gsheni gsheni deleted the sort_reqs-1 branch June 28, 2022 14:36
@ozzieD ozzieD mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsheni @rwedge