Add periods parameter to Diff primitive and add DiffDatetime primitive - #2155
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2155 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 143 143
Lines 17196 17230 +34
=======================================
+ Hits 17065 17099 +34
Misses 131 131
Continue to review full report at Codecov.
|
|
Are we good to merge this? Or would you like another review? |
I'm in the middle of updating this now since we came to the conclusion that it needs to be a separate primitive. |
tamargrey
left a comment
There was a problem hiding this comment.
Small comment about the api reference, but other than that, looks good!
gapparameter to Diff primitive #1805periodsparameter inDiffso we can shift the difference on time series dataDiffDatetimeprimitive