-
Notifications
You must be signed in to change notification settings - Fork 898
Add periods parameter to Diff primitive and add DiffDatetime primitive #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2155 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 143 143
Lines 17196 17230 +34
=======================================
+ Hits 17065 17099 +34
Misses 131 131
Continue to review full report at Codecov.
|
Are we good to merge this? Or would you like another review? |
I'm in the middle of updating this now since we came to the conclusion that it needs to be a separate primitive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about the api reference, but other than that, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
gap
parameter to Diff primitive #1805periods
parameter inDiff
so we can shift the difference on time series dataDiffDatetime
primitive