Skip to content

Add periods parameter to Diff primitive and add DiffDatetime primitive #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 7, 2022

Conversation

ozzieD
Copy link
Contributor

@ozzieD ozzieD commented Jun 28, 2022

@ozzieD ozzieD requested a review from tamargrey June 28, 2022 22:54
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #2155 (eb13d4c) into main (8a0d53f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head eb13d4c differs from pull request most recent head e5117a1. Consider uploading reports for the commit e5117a1 to get more accurate results

@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         143      143           
  Lines       17196    17230   +34     
=======================================
+ Hits        17065    17099   +34     
  Misses        131      131           
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 99.86% <100.00%> (+<0.01%) ⬆️
featuretools/tests/entityset_tests/test_es.py 100.00% <0.00%> (ø)
featuretools/tests/selection/test_selection.py 100.00% <0.00%> (ø)
featuretools/tests/utils_tests/test_gen_utils.py 100.00% <0.00%> (ø)
...aturetools/tests/primitive_tests/test_agg_feats.py 99.51% <0.00%> (ø)
...uretools/tests/entityset_tests/test_es_metadata.py 100.00% <0.00%> (ø)
...retools/tests/primitive_tests/test_feature_base.py 100.00% <0.00%> (ø)
...ools/tests/primitive_tests/test_direct_features.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d526d0...e5117a1. Read the comment docs.

@gsheni gsheni changed the title add periods parameter to shift data in Diff primitive Add gap parameter to Diff primitive to shift data Jun 30, 2022
@gsheni gsheni requested a review from tamargrey June 30, 2022 15:39
@gsheni
Copy link
Contributor

gsheni commented Jul 1, 2022

Are we good to merge this? Or would you like another review?

@ozzieD
Copy link
Contributor Author

ozzieD commented Jul 1, 2022

Are we good to merge this? Or would you like another review?

I'm in the middle of updating this now since we came to the conclusion that it needs to be a separate primitive.

@ozzieD ozzieD changed the title Add gap parameter to Diff primitive to shift data Add periods parameter to Diff primitive and add DiffDatetime primitive Jul 1, 2022
tamargrey
tamargrey previously approved these changes Jul 7, 2022
Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about the api reference, but other than that, looks good!

Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ozzieD ozzieD enabled auto-merge (squash) July 7, 2022 20:21
@ozzieD ozzieD merged commit b58ff47 into main Jul 7, 2022
@ozzieD ozzieD deleted the 1805-add-gap-parameter-to-diff-primitive branch July 7, 2022 20:34
This was referenced Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gap parameter to Diff primitive
3 participants