Skip to content

Pass kwargs into dfs call in get_valid_primitives to allow other dfs parameters to be passed in #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2022
Merged

Pass kwargs into dfs call in get_valid_primitives to allow other dfs parameters to be passed in #2157

merged 4 commits into from
Jun 30, 2022

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Jun 29, 2022 •
edited by gsheni
Loading

closes #2158

@codecov
Copy link

codecov bot commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #2157 (1d36a47) into main (09815ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1d36a47 differs from pull request most recent head 17a2b78. Consider uploading reports for the commit 17a2b78 to get more accurate results

@@           Coverage Diff           @@
##             main    #2157   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         143      143           
  Lines       16907    16917   +10     
=======================================
+ Hits        16775    16785   +10     
  Misses        132      132
Impacted Files Coverage Δ
featuretools/synthesis/get_valid_primitives.py 100.00% <ø> (ø)
...tools/tests/synthesis/test_get_valid_primitives.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09815ef...17a2b78. Read the comment docs.

@gsheni gsheni mentioned this pull request Jun 29, 2022
Closed
thehomebrewnerd
thehomebrewnerd previously approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one small spelling error.

rwedge
rwedge reviewed Jun 29, 2022
View reviewed changes
@tamargrey tamargrey force-pushed the add-kwargs-to-get-valid-primitives branch from eb246e1 to 1d36a47 Compare June 30, 2022 12:47
@tamargrey tamargrey force-pushed the add-kwargs-to-get-valid-primitives branch from 1d36a47 to 17a2b78 Compare June 30, 2022 12:49
thehomebrewnerd
thehomebrewnerd approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamargrey tamargrey merged commit 20dbcb4 into main Jun 30, 2022
@tamargrey tamargrey deleted the add-kwargs-to-get-valid-primitives branch June 30, 2022 13:56
@ozzieD ozzieD mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@rwedge rwedge Awaiting requested review from rwedge

Assignees

@tamargrey tamargrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow other dfs parameters to be used in get_valid_primitives
3 participants
@tamargrey @thehomebrewnerd @rwedge