Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DFS documentation to include more details regarding single tab… #2160

Merged
merged 22 commits into from
Jul 6, 2022

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Jun 29, 2022

Update DFS documentation to add info about alternative method to passing single table to DFS.

-- Adds warnings about the limitations of DFS with only a single table
-- Adds example about how to pass a single dataframe to DFS without creating EntitySet

Fixes #2132

@sbadithe sbadithe self-assigned this Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #2160 (cbaa92d) into main (a7ca20f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2160   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         143      143           
  Lines       17199    17199           
=======================================
  Hits        17068    17068           
  Misses        131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ca20f...cbaa92d. Read the comment docs.

@@ -785,6 +785,10 @@
"\n",
"You can run DFS on a single table. Featuretools will be able to generate features for your data, but only transform features.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to expand on this and better highlight why single table isn't recommended

@sbadithe sbadithe changed the title Update DFS documentation to include more details regarding single tab… [DRAFT] Update DFS documentation to include more details regarding single tab… Jun 30, 2022
@sbadithe sbadithe marked this pull request as ready for review July 5, 2022 20:47
@sbadithe sbadithe changed the title [DRAFT] Update DFS documentation to include more details regarding single tab… Update DFS documentation to include more details regarding single tab… Jul 5, 2022
@gsheni
Copy link
Contributor

gsheni commented Jul 6, 2022

Overall, this looks good and should be good to merge after link is added

@gsheni gsheni enabled auto-merge (squash) July 6, 2022 16:59
@gsheni gsheni merged commit 6030658 into main Jul 6, 2022
@gsheni gsheni deleted the document-single-table-dfs branch July 6, 2022 17:20
This was referenced Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create design doc for single table DFS
2 participants