Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 24th hour from and add 0th hour to PartOfDay #2167

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

tamargrey
Copy link
Contributor

Fixes bug where any timestamps from the 0th hour of a day wouldn't get transformed correctly to midnight

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2167 (1c1e5f7) into main (aac6e8c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         143      143           
  Lines       17199    17199           
=======================================
  Hits        17068    17068           
  Misses        131      131           
Impacted Files Coverage Δ
.../tests/primitive_tests/test_transform_primitive.py 100.00% <ø> (ø)
...imitives/standard/datetime_transform_primitives.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac6e8c...1c1e5f7. Read the comment docs.

@tamargrey tamargrey merged commit 629f046 into main Jul 5, 2022
@tamargrey tamargrey deleted the fix-part-of-day-hours branch July 5, 2022 18:38
@tamargrey tamargrey mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants