-
Notifications
You must be signed in to change notification settings - Fork 908
Add RollingTrend primitives and refactor some util methods #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a couple small comments after a quick scan - need a little more time to digest what is happening in the new primitive.
featuretools/primitives/standard/rolling_transform_primitive.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2170 +/- ##
==========================================
+ Coverage 99.26% 99.29% +0.03%
==========================================
Files 143 145 +2
Lines 17506 17556 +50
==========================================
+ Hits 17377 17432 +55
+ Misses 129 124 -5
Continue to review full report at Codecov.
|
tamargrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Woodwork tests should fix hopefully with #2182! |
… into 1806-add-rollingtrend-primitive
add timestamp case
Resolves: #1806
also fix code coverage issues