Skip to content

Add create feedstock PR workflow#2181

Merged
gsheni merged 88 commits into
mainfrom
add_conda_create_pr
Jul 22, 2022
Merged

Add create feedstock PR workflow#2181
gsheni merged 88 commits into
mainfrom
add_conda_create_pr

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Jul 15, 2022 •
edited
Loading

@gsheni gsheni self-assigned this Jul 18, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #2181 (787b8eb) into main (c8ed35a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2181   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         145      145           
  Lines       17556    17556           
=======================================
  Hits        17432    17432           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ed35a...787b8eb. Read the comment docs.

@gsheni gsheni changed the title Add conda create pr Add create feedstock PR workflow Jul 19, 2022
@gsheni gsheni requested a review from thehomebrewnerd July 20, 2022 18:04
@gsheni gsheni marked this pull request as ready for review July 20, 2022 18:05
thehomebrewnerd
thehomebrewnerd reviewed Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent for this to create a PR or just get everything ready and then we have to manually launch the PR with the last link that is echoed?

Also, should we create a branch in the forked repo rather than pushing the updated meta.yaml to main?

Comment thread .github/workflows/feedstock_pr_create.yaml
Comment thread .github/workflows/feedstock_pr_create.yaml
@@ -0,0 +1,55 @@
on:
workflow_dispatch:
Copy link
Copy Markdown
Contributor

@thehomebrewnerd thehomebrewnerd Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here that once the pypi release is done we would manually trigger this workflow with the new version to create the feedstock PR?

Copy link
Copy Markdown
Contributor Author

@gsheni gsheni Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated release.md with the instructions

Copy link
Copy Markdown
Contributor

@rwedge rwedge Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the release github action kick off this workflow after it finishes the pypi upload?

Copy link
Copy Markdown
Contributor Author

@gsheni gsheni Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwedge What about this?
f56f48f

@gsheni gsheni requested a review from rwedge July 21, 2022 15:15
@gsheni gsheni requested a review from thehomebrewnerd July 21, 2022 18:28
rwedge
rwedge reviewed Jul 21, 2022
View reviewed changes
Comment thread .github/workflows/create_feedstock_pr.yaml
@gsheni @rwedge
Update .github/workflows/create_feedstock_pr.yaml
3897446 
Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
rwedge
rwedge reviewed Jul 21, 2022
View reviewed changes
Comment thread docs/source/release_notes.rst Outdated
Comment thread release.md

## Release on conda-forge

In order to release on conda-forge, you can either wait for a bot to create a PR, or manually kickoff the creation with GitHub Actions
Copy link
Copy Markdown
Contributor

@rwedge rwedge Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we've confirmed the release workflow can kick off the action we should update this section

Copy link
Copy Markdown
Contributor Author

@gsheni gsheni Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

gsheni and others added 2 commits July 21, 2022 14:42
@gsheni
Update create_feedstock_pr.yaml
ecb8e4e
@gsheni @rwedge
Update docs/source/release_notes.rst
6496412 
Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
thehomebrewnerd
thehomebrewnerd reviewed Jul 22, 2022
View reviewed changes
Comment thread release.md Outdated
Comment thread docs/source/release_notes.rst Outdated
@gsheni gsheni force-pushed the add_conda_create_pr branch from 392d30b to bbf6e81 Compare July 22, 2022 15:24
@gsheni gsheni requested review from rwedge and thehomebrewnerd July 22, 2022 15:38
@gsheni gsheni merged commit 682e351 into main Jul 22, 2022
@gsheni gsheni deleted the add_conda_create_pr branch July 22, 2022 17:31
@rwedge rwedge mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwedge rwedge Awaiting requested review from rwedge

1 more reviewer

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsheni @thehomebrewnerd @rwedge