Skip to content

Fix Woodwork 0.17.0 Integration Test Failures#2182

Merged
dvreed77 merged 8 commits intomainfrom
woodwork-integration-failures
Jul 18, 2022
Merged

Fix Woodwork 0.17.0 Integration Test Failures#2182
dvreed77 merged 8 commits intomainfrom
woodwork-integration-failures

Conversation

@sbadithe
Copy link
Copy Markdown
Contributor

@sbadithe sbadithe commented Jul 15, 2022

-- Fix bool * numeric test failure in test_transform_features.py by setting numeric column to Double type.
-- Set logical type for num_square_feet in stores dataframe when creating mock_ecommerce_entityset

@sbadithe sbadithe changed the title Addresses Woodwork Integration Test Failures Addresses Woodwork 0.17.0 Integration Test Failures Jul 15, 2022
@sbadithe sbadithe changed the title Addresses Woodwork 0.17.0 Integration Test Failures Fix Woodwork 0.17.0 Integration Test Failures Jul 15, 2022
@sbadithe sbadithe marked this pull request as ready for review July 15, 2022 22:19
@sbadithe sbadithe enabled auto-merge (squash) July 15, 2022 23:14
@sbadithe sbadithe disabled auto-merge July 15, 2022 23:24
@sbadithe sbadithe requested a review from dvreed77 July 16, 2022 00:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2182 (60b219a) into main (8a0d53f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2182      +/-   ##
==========================================
+ Coverage   99.23%   99.25%   +0.01%     
==========================================
  Files         143      143              
  Lines       17196    17508     +312     
==========================================
+ Hits        17065    17378     +313     
+ Misses        131      130       -1     
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 100.00% <ø> (ø)
featuretools/computational_backends/feature_set.py 100.00% <ø> (ø)
...s/computational_backends/feature_set_calculator.py 98.69% <ø> (ø)
featuretools/computational_backends/utils.py 96.61% <ø> (+0.01%) ⬆️
featuretools/demo/flight.py 96.10% <ø> (ø)
featuretools/demo/mock_customer.py 95.23% <ø> (ø)
featuretools/demo/weather.py 100.00% <ø> (ø)
featuretools/entityset/deserialize.py 100.00% <ø> (ø)
featuretools/entityset/entityset.py 99.22% <ø> (+<0.01%) ⬆️
featuretools/entityset/relationship.py 98.83% <ø> (+0.11%) ⬆️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73744e7...60b219a. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvreed77 dvreed77 merged commit 33564e6 into main Jul 18, 2022
@dvreed77 dvreed77 deleted the woodwork-integration-failures branch July 18, 2022 13:06
This was referenced Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants