remove convert_links_to_integers #219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the keyword argument
convert_links_to_integers
from normalize entity.Some of the
last_time_index
tests were using a normalization withconvert_links_to_integers
and sorting values, leading to a resort of the "true" values in the test.Original ordering was
if we convert these to range(11) and sort them according to the value in the list above, the new ordering of that range would become
which aligns exactly with the changes we had to make in
true_values_lti
.The other change, changing the
value
intest_parent_some_missing
, is really a convenience measure to ensure that it ends up second to last on the sorted list. If we put it earlier, we'll have to move all the rows instead of just one.