Skip to content

Update Trend primitive to work with Int64 inputs #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Update Trend primitive to work with Int64 inputs #2204

merged 4 commits into from
Jul 26, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Update Trend primitive to work with Int64 inputs

Fixes #2201

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2204 (1780f5f) into main (a76354c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2204   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         146      146           
  Lines       17567    17577   +10     
=======================================
+ Hits        17443    17453   +10     
  Misses        124      124           
Impacted Files Coverage Δ
...tools/tests/primitive_tests/test_agg_primitives.py 100.00% <100.00%> (ø)
featuretools/tests/utils_tests/test_time_utils.py 96.61% <100.00%> (ø)
featuretools/utils/time_utils.py 95.16% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76354c...1780f5f. Read the comment docs.

@@ -7,6 +7,7 @@ Future Release
==============
* Enhancements
* Fixes
* Update ``Trend`` primitive to work with ``IntegerNullable`` inputs (:pr:`2204``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes RollingTrend since it uses the same function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call - I updated to reflect that.

Co-authored-by: ozzieD <odembowski@alteryx.com>
@gsheni gsheni merged commit 353d539 into main Jul 26, 2022
@gsheni gsheni deleted the trend-bug branch July 26, 2022 14:11
@rwedge rwedge mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trend primitive fails with IntegerNullable inputs
4 participants