Extract rolling primitives logic into a general function#2218
Conversation
ozzieD
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2218 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 146 146
Lines 17594 17583 -11
==========================================
- Hits 17470 17459 -11
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ozzieD
changed the title
| [RollingCount, RollingMax, RollingMin, RollingMean, RollingSTD, RollingTrend], | ||
| ) | ||
| @patch("featuretools.primitives.rolling_primitive_utils.apply_roll_with_offset_gap") | ||
| def test_no_call_to_apply_roll_with_offset_gap_with_numeric( |
There was a problem hiding this comment.
this test was moved to the utils test since it is testing the utils function more than the actual primitives
| window_size="test", | ||
| gap="7D", | ||
| min_periods=1, | ||
| ) |
There was a problem hiding this comment.
lots of black, pre-commit linting changes
There was a problem hiding this comment.
Do you know if there were any non linting changes to the actual test checks? I haven't seen any, but just want to make sure I'm not missing anything.
There was a problem hiding this comment.
Only change is specifying the min_periods parameter for roll_series_with_gap. I rolled the default parameters up to apply_rolling_agg_to_series so existing functions like roll_series_with_gap no longer need a default value.
sbadithe
left a comment
sbadithe
left a comment
There was a problem hiding this comment.
just minor grammar suggestions
tamargrey
left a comment
tamargrey
left a comment
There was a problem hiding this comment.
Thank you for doing this! Makes the logic around rolling primitives feel a lot more manageable
| window_size="test", | ||
| gap="7D", | ||
| min_periods=1, | ||
| ) |
There was a problem hiding this comment.
Do you know if there were any non linting changes to the actual test checks? I haven't seen any, but just want to make sure I'm not missing anything.
gsheni
changed the title
4 participants
resolves: #2213