Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split primitive descriptions on blank line instead of first line break to avoid truncating descriptions #2219

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

tamargrey
Copy link
Contributor

Fixes #2217

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2219 (c315484) into main (31d80ab) will increase coverage by 44.70%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2219       +/-   ##
===========================================
+ Coverage   54.58%   99.29%   +44.70%     
===========================================
  Files         146      146               
  Lines       17579    17594       +15     
===========================================
+ Hits         9596    17470     +7874     
+ Misses       7983      124     -7859     
Impacted Files Coverage Δ
featuretools/primitives/utils.py 99.51% <100.00%> (+47.80%) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100.00% <100.00%> (+100.00%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 99.07% <0.00%> (+1.38%) ⬆️
...primitives/standard/rolling_transform_primitive.py 100.00% <0.00%> (+1.72%) ⬆️
...imitives/standard/datetime_transform_primitives.py 100.00% <0.00%> (+2.50%) ⬆️
featuretools/synthesis/utils.py 100.00% <0.00%> (+2.77%) ⬆️
...retools/primitives/standard/transform_primitive.py 100.00% <0.00%> (+2.97%) ⬆️
featuretools/utils/time_utils.py 95.16% <0.00%> (+3.22%) ⬆️
...rimitives/standard/latlong_transform_primitives.py 100.00% <0.00%> (+3.63%) ⬆️
featuretools/tests/testing_utils/es_utils.py 100.00% <0.00%> (+4.34%) ⬆️
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ozzieD ozzieD self-requested a review August 4, 2022 15:39
@tamargrey tamargrey force-pushed the truncated-primitive-descriptions branch from 08028d0 to c315484 Compare August 4, 2022 15:49
@tamargrey tamargrey merged commit b90cb83 into main Aug 4, 2022
@tamargrey tamargrey deleted the truncated-primitive-descriptions branch August 4, 2022 16:52
@rwedge rwedge mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent primitive descriptions from being truncated
2 participants