Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camel_and_title_to_snake handles snake string with numbers #2220

Merged
merged 4 commits into from
Aug 4, 2022
Merged

camel_and_title_to_snake handles snake string with numbers #2220

merged 4 commits into from
Aug 4, 2022

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Aug 3, 2022

Fixes #2195

@rwedge rwedge marked this pull request as ready for review August 4, 2022 00:11
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #2220 (c79d8dd) into main (d42ecf1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         146      146           
  Lines       17577    17579    +2     
=======================================
+ Hits        17453    17455    +2     
  Misses        124      124
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 99.07% <ø> (ø)
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.34% <ø> (ø)
featuretools/tests/utils_tests/test_gen_utils.py 100.00% <100.00%> (ø)
featuretools/utils/gen_utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dvreed77
dvreed77 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwedge rwedge merged commit 31d80ab into main Aug 4, 2022
@rwedge rwedge deleted the issue-2195-rw branch August 4, 2022 15:48
@rwedge rwedge mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvreed77 dvreed77 dvreed77 approved these changes

@tamargrey tamargrey Awaiting requested review from tamargrey

Assignees

@rwedge rwedge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

camel_and_title_to_snake breaks for camelcase input
2 participants
@rwedge @dvreed77