Refactors build_features to improve performance#2224
Merged
Conversation
cp2boston
requested review from
dvreed77,
gsheni,
rwedge,
tamargrey and
thehomebrewnerd
August 5, 2022 11:54
|
|
cp2boston
marked this pull request as draft
August 5, 2022 13:05
gsheni
requested review from
ozzieD and
sbadithe
and removed request for
dvreed77
August 5, 2022 14:52
gsheni
reviewed
Aug 5, 2022
sbadithe
reviewed
Aug 5, 2022
sbadithe
reviewed
Aug 5, 2022
added 3 commits
August 5, 2022 15:59
- removed Dockerfile.arm and .dockerignore - created feature_base/cache.py - modified cache to be enabld for DFS only - reverted test modifications
gsheni
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
+ Coverage 99.29% 99.32% +0.02%
==========================================
Files 146 148 +2
Lines 17585 17657 +72
==========================================
+ Hits 17461 17537 +76
+ Misses 124 120 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rwedge
reviewed
Aug 11, 2022
…eryx/featuretools into TML-4492_build-features-perf Updated release_notes.rst
- add cached get_featrue_depth to DFS
thehomebrewnerd
approved these changes
Aug 24, 2022
thehomebrewnerd
left a comment
thehomebrewnerd
left a comment
Contributor
There was a problem hiding this comment.
Seems fine to me, but not sure I completely followed all the refactors. Might be good to get a second opinion before merging.
|
|
||
| Thanks to the following people for contributing to this release: | ||
| :user:`cp2boston`, :user:`gsheni` | ||
| :user:`cpark`, :user:`gsheni` |
Contributor
There was a problem hiding this comment.
Correct user name?
rwedge
reviewed
Aug 24, 2022
| Thanks to the following people for contributing to this release: | ||
| :user:`cp2boston`, :user:`gsheni` | ||
| :user:`cpark`, :user:`gsheni` | ||
|
|
rwedge
approved these changes
Aug 24, 2022
ozzieD
approved these changes
Aug 24, 2022
gsheni
reviewed
Aug 24, 2022
gsheni
reviewed
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR contains refactors within the
build_featurescode path that are focused on improving the performance. There are some new files: