Improve version comparison in check_schema_version util function #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbadithe
commented
Aug 7, 2022
sbadithe
commented
- Fixes Improve version comparison in check_schema_version util function #2154
gsheni
reviewed
Aug 8, 2022
|
|
||
| from packaging.version import parse |
There was a problem hiding this comment.
packaging needs to be added to setup.cfg in install_requires. It's not a part of Python standard
gsheni
suggested changes
Aug 8, 2022
…turetools into check_schema_version
sbadithe
commented
Aug 8, 2022
| @@ -49,6 +49,7 @@ install_requires = | |||
| holidays >= 0.13 | |||
| numpy >= 1.21.0 | |||
| pandas >= 1.3.0 | |||
| packaging >= 20.0 | |||
There was a problem hiding this comment.
It looks like distributed has packaging >= 20.0 as a req so I put this as the minimal version. It's also the release of packaging that supports Python3.8
gsheni
approved these changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 146 146
Lines 17583 17577 -6
==========================================
- Hits 17459 17453 -6
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.