Allow boolean columns to be included in remove_highly_correlated_features #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2231 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 146 146
Lines 17577 17590 +13
=======================================
+ Hits 17453 17466 +13
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
reviewed
Aug 8, 2022
| # Convert boolean column to be float64 | ||
| if pd.api.types.is_bool_dtype(less_complex_col): | ||
| less_complex_col = less_complex_col.astype("float64") | ||
|
|
||
| if abs(more_complex_col.corr(less_complex_col)) >= pct_corr_threshold: |
There was a problem hiding this comment.
Noob question but is it a normal case for corr to be nan?
There was a problem hiding this comment.
It's possible for the column type to LatLong or a logical type where you cannot calculate the correlation value.
There was a problem hiding this comment.
Makes sense. Also, I didn't realize that the feature matrix had columns of all zeros (like bools = diff_ints), which makes correlation being nan make perfect sense.
sbadithe
reviewed
Aug 8, 2022
| @@ -330,3 +331,42 @@ def test_multi_output_selection(): | |||
| for f in unsliced_features: | |||
| for f_name in f.get_feature_names(): | |||
| assert f_name in matrix_columns | |||
|
|
|||
|
|
|||
| def test_remove_highly_correlatied_features_on_boolean_cols(): | |||
There was a problem hiding this comment.
Suggested change
| def test_remove_highly_correlatied_features_on_boolean_cols(): | |
| def test_remove_highly_correlated_features_on_boolean_cols(): |
added 3 commits
August 9, 2022 16:45
tamargrey
force-pushed
the
fix-corr-on-bools
branch
from
7200f03 to
e61b05b
Compare
sbadithe
approved these changes
Aug 9, 2022
rwedge
approved these changes
Aug 10, 2022
gsheni
approved these changes
Aug 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2229
Converts boolean columns to
float64inremove_highly_correlated_featuresto avoid the error that comes from callingcorron boolean columns