Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release workflow to kickoff conda create pull request #2237

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Update release workflow to kickoff conda create pull request #2237

merged 5 commits into from
Aug 10, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 10, 2022 •
edited
Loading

  • This will make it so the Create Conda Pull Request workflow gets auto kicked off after releasing to PyPI
  • Updated the release.md to specify this information

@gsheni gsheni self-assigned this Aug 10, 2022
@gsheni gsheni changed the title Update release.yaml Remove conda create workflow kickoff from release workflow Aug 10, 2022
@gsheni gsheni requested a review from rwedge August 10, 2022 16:51
@gsheni gsheni marked this pull request as ready for review August 10, 2022 16:51
@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #2237 (b92761f) into main (079c882) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2237   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         146      146           
  Lines       17590    17590           
=======================================
  Hits        17466    17466           
  Misses        124      124

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni enabled auto-merge (squash) August 10, 2022 17:08
@gsheni gsheni requested a review from sbadithe August 10, 2022 17:08
@rwedge
Copy link
Contributor

rwedge commented Aug 10, 2022

Why isn't this needed?

@gsheni
Copy link
Contributor Author

gsheni commented Aug 10, 2022

@sbadithe @rwedge I added it back and fixed the wording in release.md

@gsheni gsheni changed the title Remove conda create workflow kickoff from release workflow Update release workflow to kickoff conda create pull request Aug 10, 2022
rwedge
rwedge approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit d32779f into main Aug 10, 2022
@gsheni gsheni deleted the remove_workflow_kickoff branch August 10, 2022 20:21
@ozzieD ozzieD mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@sbadithe sbadithe Awaiting requested review from sbadithe

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsheni @rwedge