upgrade min version of pandas and remove rolling primitives workaround #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Aug 16, 2022
gsheni
approved these changes
Aug 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 146 146
Lines 17590 17588 -2
==========================================
- Hits 17466 17464 -2
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
You'll need to update the |
…into 1771-remove-workaround-rolling
|
@ozzieD I think there is a unit test error showing up due to the new min pandas: |
ozzieD
changed the title
ozzieD
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1771 and #2241