Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused kwargs from query_by_values, filter_and_sort #225

merged 1 commit into from Aug 22, 2018


Copy link

@Seth-Rothschild Seth-Rothschild commented Aug 21, 2018

There are 5 keyword arguments to query_by_values and filter_and_sort that were unused outside of tests:

  • return_sorted=False
  • start=None
  • end=None
  • random_seed=None
  • shuffle=False

This PR removes those arguments, the associated docstring segment and the two tests that were testing return_sorted.

Copy link

Codecov Report

Merging #225 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
+ Coverage   93.52%   93.58%   +0.05%     
  Files          71       71              
  Lines        7749     7727      -22     
- Hits         7247     7231      -16     
+ Misses        502      496       -6
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/ 99.3% <ø> (-0.01%) ⬇️
featuretools/entityset/ 88.8% <ø> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5ddf1...cfb39d8. Read the comment docs.

Copy link

kmax12 commented Aug 22, 2018

Looks good. Merging

@kmax12 kmax12 merged commit e6ba81e into master Aug 22, 2018
@Seth-Rothschild Seth-Rothschild deleted the query_by_values_kwargs branch August 22, 2018 17:04
@rwedge rwedge mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants