Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic Lag primitive #2252

Merged
merged 28 commits into from
Aug 31, 2022
Merged

Add generic Lag primitive #2252

merged 28 commits into from
Aug 31, 2022

Conversation

ozzieD
Copy link
Contributor

@ozzieD ozzieD commented Aug 22, 2022 •
edited by gsheni
Loading

Pull Request Description

Resolves #1781

@gsheni gsheni changed the title 1781 add lagbyperiods primitive Add generic Lag primitive Aug 22, 2022
@gsheni gsheni mentioned this pull request Aug 22, 2022
Merged
@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #2252 (d5e4402) into main (ecd5111) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files         148      148           
  Lines       17657    17706   +49     
=======================================
+ Hits        17537    17586   +49     
  Misses        120      120
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 99.87% <100.00%> (+<0.01%) ⬆️
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thehomebrewnerd
thehomebrewnerd reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to discuss any of my comments in more detail if that would be helpful.

docs/source/release_notes.rst Show resolved Hide resolved
featuretools/primitives/standard/transform_primitive.py Show resolved Hide resolved
featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_primitive_utils.py Outdated Show resolved Hide resolved
featuretools/primitives/standard/transform_primitive.py Show resolved Hide resolved
featuretools/tests/primitive_tests/test_transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_transform_primitive.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_transform_features.py Show resolved Hide resolved
@ozzieD ozzieD mentioned this pull request Aug 30, 2022
Open
thehomebrewnerd
thehomebrewnerd reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last minor comment, but once the linting is fixed and the CI passes with the latest changes from main, I'll approve.

featuretools/tests/primitive_tests/test_transform_features.py Outdated Show resolved Hide resolved
@ozzieD ozzieD enabled auto-merge (squash) August 31, 2022 21:08
thehomebrewnerd
thehomebrewnerd approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming CI tests pass.

@ozzieD ozzieD merged commit 1876fed into main Aug 31, 2022
@ozzieD ozzieD deleted the 1781-add-lagbyperiods-primitive branch August 31, 2022 21:52
@stefaniesmith stefaniesmith mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni left review comments

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@rwedge rwedge Awaiting requested review from rwedge

@tamargrey tamargrey Awaiting requested review from tamargrey

Assignees

@ozzieD ozzieD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Lag primitive
5 participants
@ozzieD @thehomebrewnerd @rwedge @gsheni @tamargrey