Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holidays library failure with lookups #2254

Merged
merged 11 commits into from Aug 23, 2022

Conversation

cp2boston
Copy link
Contributor

@cp2boston cp2boston commented Aug 22, 2022

@cp2boston cp2boston linked an issue Aug 22, 2022 that may be closed by this pull request
@cp2boston cp2boston requested a review from rwedge August 22, 2022 20:43
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #2254 (eb44a37) into main (76c20d7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2254      +/-   ##
==========================================
- Coverage   99.29%   99.29%   -0.01%     
==========================================
  Files         146      146              
  Lines       17588    17585       -3     
==========================================
- Hits        17464    17461       -3     
  Misses        124      124              
Impacted Files Coverage Δ
...imitives/standard/datetime_transform_primitives.py 100.00% <100.00%> (ø)
featuretools/primitives/utils.py 99.52% <100.00%> (+<0.01%) ⬆️
...rimitive_tests/test_distancetoholiday_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cp2boston cp2boston requested a review from gsheni August 22, 2022 20:50
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we planning to drop support for older versions of the holidays package? If so we should update the requirements in setup.cfg

@gsheni gsheni changed the title 2253 holidays library update causes lookup failures Fix holidays library failure with lookups Aug 22, 2022
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion on the release note wording but otherwise LGTM

Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
@cp2boston cp2boston merged commit 45a06f1 into main Aug 23, 2022
@cp2boston cp2boston deleted the 2253-holidays-library-update-causes-lookup-failures branch August 23, 2022 13:51
@stefaniesmith stefaniesmith mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holidays library update causes lookup failures
3 participants