-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix holidays library failure with lookups #2254
Fix holidays library failure with lookups #2254
Conversation
…x/featuretools into latest-dep-update-76c20d7
Codecov Report
@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 146 146
Lines 17588 17585 -3
==========================================
- Hits 17464 17461 -3
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we planning to drop support for older versions of the holidays package? If so we should update the requirements in setup.cfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a suggestion on the release note wording but otherwise LGTM
Co-authored-by: Roy Wedge <roy.wedge@alteryx.com>
def test_holiday_out_of_range()
to use correct number of days