Adds series_library attribute to EntitySet dictionary
#2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turetools into entityset-series-lib
rwedge
reviewed
Sep 1, 2022
featuretools/tests/primitive_tests/test_feature_serialization.py
Outdated
Show resolved
Hide resolved
sbadithe
changed the title
series_library attribute to EntitySet dictionaryseries_library attribute to EntitySet dictionary
sbadithe
commented
Sep 2, 2022
gsheni
reviewed
Sep 2, 2022
gsheni
reviewed
Sep 2, 2022
Contributor
gsheni
left a comment
gsheni
left a comment
There was a problem hiding this comment.
Overall this looks good to me. I would want to wait until EvalML support Woodwork v0.18.0 before merging this in
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
Contributor
|
Woodwork has gone out with release v0.19.0 so this PR is ready to be merged in |
rwedge
reviewed
Sep 27, 2022
gsheni
approved these changes
Sep 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
series_libraryattribute toprimitive_baseEntitySetduring serialization to lessen complexity (the alternative would be to store it on every primitive object)empty_dataframeto return the correctly typed dataframe, instead of always returning a pandas one. This solves the problem of serializing your entityset with dask dataframes, and deserializing them but getting pandas ones.