Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum dependency generator #2263

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Fix minimum dependency generator #2263

merged 2 commits into from
Aug 30, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 30, 2022

  • Fixes
  File "/minimum_dependency_generator/minimum_dependency_generator.py", line 134, in parse_pyproject_toml
    requirements += toml_dict["project"][option]
KeyError: 'install_requires'

@gsheni gsheni self-assigned this Aug 30, 2022
@gsheni gsheni changed the title Update minimum_dependency_checker.yaml Fix minimum dependency checker Aug 30, 2022
@gsheni gsheni changed the title Fix minimum dependency checker Fix minimum dependency generator Aug 30, 2022
@gsheni gsheni marked this pull request as ready for review August 30, 2022 15:29
@gsheni gsheni enabled auto-merge (squash) August 30, 2022 15:32
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #2263 (2b6cb43) into main (5138f42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files         148      148           
  Lines       17657    17657           
=======================================
  Hits        17537    17537           
  Misses        120      120           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni merged commit 90c0752 into main Aug 30, 2022
@gsheni gsheni deleted the fix_min_dep branch August 30, 2022 15:44
@stefaniesmith stefaniesmith mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants