Skip to content

Replace Library.MEMBER.value with Library.MEMBER - #2275

Merged
rwedge merged 2 commits into
mainfrom
library-subclasses-str
Sep 28, 2022
Merged

Replace Library.MEMBER.value with Library.MEMBER#2275
rwedge merged 2 commits into
mainfrom
library-subclasses-str

Conversation

@rwedge

@rwedge rwedge commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Now that Library.DASK == "Dask" evaluates to True we can replace Library.PANDAS.value with Library.PANDAS in a lot of places

@codecov

codecov Bot commented Sep 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2275 (a868d48) into main (1bf70ed) will increase coverage by 27.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2275       +/-   ##
===========================================
+ Coverage   72.31%   99.37%   +27.06%     
===========================================
  Files         145      145               
  Lines       17678    17678               
===========================================
+ Hits        12784    17568     +4784     
+ Misses       4894      110     -4784     
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 100.00% <100.00%> (ø)
featuretools/computational_backends/utils.py 95.65% <100.00%> (ø)
featuretools/entityset/entityset.py 99.22% <100.00%> (+0.12%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 100.00% <100.00%> (ø)
...mputational_backend/test_feature_set_calculator.py 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/test_dask_es.py 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)
...ools/tests/entityset_tests/test_last_time_index.py 100.00% <100.00%> (ø)
...eaturetools/tests/entityset_tests/test_plotting.py 100.00% <100.00%> (ø)
...etools/tests/entityset_tests/test_serialization.py 99.68% <100.00%> (ø)
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rwedge
rwedge force-pushed the library-subclasses-str branch from 0b01db7 to 3c09189 Compare September 28, 2022 20:56
@rwedge rwedge changed the title Library class subclasses str Replace Library.MEMBER.value with Library.MEMBER Sep 28, 2022
@rwedge
rwedge marked this pull request as ready for review September 28, 2022 22:02
@rwedge
rwedge requested review from gsheni and sbadithe September 28, 2022 22:02
@rwedge
rwedge merged commit d322897 into main Sep 28, 2022
@rwedge
rwedge deleted the library-subclasses-str branch September 28, 2022 22:04
@rwedge rwedge mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants