Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing doc strings #23

Merged
merged 2 commits into from Oct 30, 2017
Merged

Missing doc strings #23

merged 2 commits into from Oct 30, 2017

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Oct 25, 2017

  • Added some doc strings in binary_transform.py
  • Also cleaned up some other doc strings.

@codecov-io
Copy link

Codecov Report

Merging #23 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   86.85%   86.86%   +0.01%     
==========================================
  Files          73       73              
  Lines        6777     6778       +1     
==========================================
+ Hits         5886     5888       +2     
+ Misses        891      890       -1
Impacted Files Coverage Δ
featuretools/primitives/aggregation_primitives.py 92.1% <ø> (ø) ⬆️
featuretools/primitives/binary_transform.py 83.83% <ø> (ø) ⬆️
featuretools/primitives/transform_primitive.py 96.78% <ø> (-0.05%) ⬇️
featuretools/entityset/serialization.py 17.64% <0%> (-1.2%) ⬇️
.../feature_function_tests/test_transform_features.py 85.15% <0%> (-0.16%) ⬇️
featuretools/tests/testing_utils/mock_ds.py 94.54% <0%> (ø) ⬆️
...turetools/tests/feature_function_tests/__init__.py 100% <0%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 96.61% <0%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c5762...01013d2. Read the comment docs.

@kmax12 kmax12 merged commit bea8d95 into master Oct 30, 2017
@gsheni gsheni deleted the missing_doc_strings branch November 2, 2017 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants