Remove featuretools_sql from docs requirements#2302
Merged
thehomebrewnerd merged 6 commits intomainfrom Sep 27, 2022
Merged
Conversation
added 2 commits
September 27, 2022 09:37
Codecov Report
@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 99.31% 99.37% +0.06%
==========================================
Files 148 145 -3
Lines 17706 17661 -45
==========================================
- Hits 17584 17551 -33
+ Misses 122 110 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sbadithe
approved these changes
Sep 27, 2022
ozzieD
approved these changes
Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove featuretools_sql from docs requirements
featuretools_sqlwas listed as adocsrequirement inpyproject.toml, but there is no code executed during the docs build that actually requiresfeaturetools_sqlto be installed. Having this as a requirement means that users needed to have Postgres installed before runningmake installdeps, otherwise the installation ofpsycopg2would fail. This PR removes this requirement so that users can runmake installdepswithout having Postgres installed.