Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove featuretools_sql from docs requirements #2302

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Sep 27, 2022

Remove featuretools_sql from docs requirements

featuretools_sql was listed as a docs requirement in pyproject.toml, but there is no code executed during the docs build that actually requires featuretools_sql to be installed. Having this as a requirement means that users needed to have Postgres installed before running make installdeps, otherwise the installation of psycopg2 would fail. This PR removes this requirement so that users can run make installdeps without having Postgres installed.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #2302 (e0094fd) into main (8abf923) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2302      +/-   ##
==========================================
+ Coverage   99.31%   99.37%   +0.06%     
==========================================
  Files         148      145       -3     
  Lines       17706    17661      -45     
==========================================
- Hits        17584    17551      -33     
+ Misses        122      110      -12     
Impacted Files Coverage Δ
featuretools/synthesis/__init__.py
featuretools/selection/__init__.py
featuretools/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd changed the title Update contributing.md to include postgres install instructions Remove featuretools_sql from docs requirements Sep 27, 2022
@thehomebrewnerd thehomebrewnerd merged commit 8b3fa6c into main Sep 27, 2022
@thehomebrewnerd thehomebrewnerd deleted the postgres-contrib branch September 27, 2022 17:09
@rwedge rwedge mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants