PercentTrue uses False instead of 0 as fill value#2308
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2308 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 145 145
Lines 17678 17682 +4
=======================================
+ Hits 17568 17572 +4
Misses 110 110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thehomebrewnerd
approved these changes
Sep 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PercentTrue primitive takes Boolean or BooleanNullable input data. The primitive function fills missing values using
0but with Pandas 1.5 that does not seems to be supported for "Boolean" dtype. This PR changes the fill value toFalse