Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PercentTrue uses False instead of 0 as fill value #2308

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Sep 30, 2022

PercentTrue primitive takes Boolean or BooleanNullable input data. The primitive function fills missing values using 0 but with Pandas 1.5 that does not seems to be supported for "Boolean" dtype. This PR changes the fill value to False

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #2308 (6ffc475) into main (d322897) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         145      145           
  Lines       17678    17682    +4     
=======================================
+ Hits        17568    17572    +4     
  Misses        110      110           
Impacted Files Coverage Δ
...ools/primitives/standard/aggregation_primitives.py 99.68% <100.00%> (ø)
...tools/tests/primitive_tests/test_agg_primitives.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rwedge rwedge marked this pull request as ready for review September 30, 2022 20:09
@rwedge rwedge enabled auto-merge (squash) September 30, 2022 20:09
@rwedge rwedge merged commit c73c351 into main Sep 30, 2022
@rwedge rwedge deleted the pd-1-5-pct-true branch September 30, 2022 20:23
@rwedge rwedge mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants